Link checker parses headings inside component #2230
Merged
+43
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
changed the title
frankharkins
approved these changes
Nov 4, 2024
I don't think so - think about how slow checkPagesRender.ts is. It's important our link checker handles all historical API docs as well; the closed source link checker doesn't do that because its live render approach is too slow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link checker was failing to detect inline class methods (related to #2210) because it does not peek inside
<Class>components.To fix this, we now use our own parsing code for headings.
It's possible there will be future edge cases this PR does not account for in its heading parsing. Our link checker will fail in that case and we can forward fix.